Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/3375#discussion_r21477718
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashOuterJoin.scala
---
@@ -68,62 +68,59 @@ case class HashOuterJoin(
@transient private[this] lazy val DUMMY_LIST = Seq[Row](null)
@transient private[this] lazy val EMPTY_LIST = Seq.empty[Row]
+ @transient private[this] lazy val joinedRow = new JoinedRow()
--- End diff --
I believe that it is working now, but my objection is primarily to having
mutable state stored inside of the task instead of local to a single execution.
If we decide to be more clever about sharing task metadata in the future this
could break in a very subtle ways. Also, the cost of accessing a lazy val is
almost certainly higher than accessing a local stack variable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
