Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3634#discussion_r21479585
--- Diff:
external/flume-sink/src/main/scala/org/apache/spark/streaming/flume/sink/SparkAvroCallbackHandler.scala
---
@@ -47,8 +47,8 @@ private[flume] class SparkAvroCallbackHandler(val
threads: Int, val channel: Cha
val transactionExecutorOpt = Option(Executors.newFixedThreadPool(threads,
new ThreadFactoryBuilder().setDaemon(true)
.setNameFormat("Spark Sink Processor Thread - %d").build()))
- private val sequenceNumberToProcessor =
- new ConcurrentHashMap[CharSequence, TransactionProcessor]()
+ // Protected by `sequenceNumberToProcessor`
--- End diff --
Could use the `@GuardedBy("sequenceNumberToProcessor")` javax annotation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
