Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3486#discussion_r21490919
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---
@@ -183,6 +193,16 @@ trait SparkListener {
* Called when the driver receives task metrics from an executor in a
heartbeat.
*/
def onExecutorMetricsUpdate(executorMetricsUpdate:
SparkListenerExecutorMetricsUpdate) { }
+
+ /**
+ * Called when the driver registers a new executor.
+ */
+ def onExecutorAdded(executorAdded: SparkListenerExecutorAdded) { }
--- End diff --
BTW doesn't this break the build? There are a few listeners in Spark code
itself (e.g. `EventLoggingListener`) which should have broken because of this.
(BTW fixing that listener means you'll probably need to touch
`JsonProtocol` to serialize these new events to the event log... and you'll
need to be careful not to keep the log URLs in the replayed UIs since they'll
most probably be broken links at that point. Meaning that probably the UI
listener should nuke the log URLs when the "executor removed" message is
handled.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
