Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/1269#issuecomment-66210825
@akopich
The test failure seems unrelated (from a Python SQL test). I'll re-run the
tests.
(2) Regular and Robust in the same class
Would it work to have the regular parameters inherit from the robust, where
the regular would override certain behavior to effectively fix the value of the
noise?
(4) Float vs. Double and linear algebra operations
I think I wasn't clear. Since you want to use Float, I don't think it
makes sense to move code to linalg/ currently. So 2 options for your code are:
(a) Keep as is (Array[Array[Float]]) or (b) Use Breeze types internally (since
they take type parameters). (a) seems OK, but (b) might make code cleaner.
Your call.
(5) Enumerator
Sure, it does seem useful. Perhaps it could go in mllib/feature/ and
follow the API of other transformers (such as HashingTF and Word2Vec).
Parameters can be set via setters like setThreshold(), and numerate() can
become transform().
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
