Github user gvramana commented on a diff in the pull request:
https://github.com/apache/spark/pull/2802#discussion_r21518099
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUdfs.scala
---
@@ -172,6 +177,8 @@ private[hive] case class
HiveGenericUdf(functionClassName: String, children: Seq
override def eval(input: Row): Any = {
returnInspector // Make sure initialized.
+ if(foldable) return constantReturnValue
--- End diff --
@chenghao-intel This PR cannot be separately merged without CreateArray,
as percentile_approx accepts only constant array iterator and fails otherwise.
I think we can go ahead and merge these changes as they don't break build or
tests, and are not directly dependent on #3429 in order of merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
