Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/3409#issuecomment-66339357
  
    Hey regarding the naming, I would actually prefer `spark.yarn.am.*` over 
`spark.yarn.clientmode.am.*`. Although I agree that it's clearer to have 
clientmode in there, it's incredibly verbose and inconsistent with the other 
similar configs that we have (i.e. `spark.driver.extraJavaOptions`, 
`spark.yarn.executor.memoryOverhead`). If we want to discourage the user from 
setting these in cluster mode, I think the better approach is to log a warning 
or even throw an exception if this happens, instead of cramming in `clientmode` 
in a config name that we can't ever change again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to