Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3643#issuecomment-66342802
Hi, it looks like this may be faster for dense vectors but not for sparse.
SparseVector.toArray will create a dense vector, making it much slower if the
vector is very sparse. You will probably need separate cases for DenseVector
and SparseVector.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
