Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3574#issuecomment-66376403
LGTM. I like how this ended up evolving into a very small, focused fix.
I'm going to fix up the title / commit message and merge this into
`master`. Even though I don't think we've observed failures from this in the
wild, I'm in favor of backporting this into the maintenance branches, too,
since it probably won't cause any harm to add more defensive checks here. I'll
merge this into `branch-1.0` and `branch-1.1` and hold off on `branch-1.2` for
now (I'll add a `backport-needed` JIRA label and pull this in after 1.2.0 is
released).
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
