Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3610#discussion_r21581982
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala ---
    @@ -43,7 +43,8 @@ class KMeans private (
         private var runs: Int,
         private var initializationMode: String,
         private var initializationSteps: Int,
    -    private var epsilon: Double) extends Serializable with Logging {
    +    private var epsilon: Double,
    +    private var seed: Long = System.nanoTime()) extends Serializable with 
Logging {
    --- End diff --
    
    Could you set the default in the one public constructor instead since 
that's where other defaults are set?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to