Github user mridulm commented on the pull request: https://github.com/apache/spark/pull/3600#issuecomment-66407791 -1 This is broken change for multiple reasons - finalize of out of scope variable can trigger close of underlying fd, potential state issue with vars not being null when we expect them to be; not to mention the cost 'saved' is fairly trivial anyway to introduce changes to this codepath. please be very careful changing disk writers in spark ... we have spent too much time debugging and fixing it; correctness and functionality is much more important than perceived performance improvement.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org