Github user lvsoft commented on the pull request:

    https://github.com/apache/spark/pull/3490#issuecomment-66414770
  
    Well, I can't understand what's the complexity of this PR. I've reviewed 
the SPARK-3779 marked as related and didn't find something related to this 
patch.
    And, this patch will be downward compatible with current `spark-submit` 
behavior.
    
    From my point of view, let's talk it level by level:
    1. In case of necessity: I've give out two reasons, one for benchmark case, 
one for common intuition in most systems.
    2. In case of complexity: This patch maintains downward compatibility, and 
I've described its detail at the beginning and didn't catch the relationship 
with SPARK-3779.
    3. In case of elegance: I don't think this is the most elegant solution. 
However, in order to maintain compatibility and least impact to current system, 
this is the relatively elegant solution.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to