Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3661#discussion_r21592824
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/ContextWaiter.scala ---
@@ -17,30 +17,74 @@
package org.apache.spark.streaming
+import java.util.concurrent.{TimeoutException, TimeUnit}
+import java.util.concurrent.locks.ReentrantLock
+import javax.annotation.concurrent.GuardedBy
+
private[streaming] class ContextWaiter {
+
+ private val lock = new ReentrantLock()
+ private val condition = lock.newCondition()
+
+ @GuardedBy("lock")
--- End diff --
Yes, that's why I brought it up. It's not actually a standard Java
annotation (unless someone tells me it just turned up in 8 or something) but
part of JSR-305. This is a dependency of Spark core at the moment, but none of
the annotations are used. I think we should just not use them instead of using
this lib in 1 place.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
