GitHub user adrian-wang opened a pull request:

    https://github.com/apache/spark/pull/3675

    [SQL] sum and avg on empty table should always return null

    So the optimizations are not valid. Also I think the optimization here is 
rarely encounter, so removing them will not have influence on performance.
    
    I'll create JIRA after jira is back. Can we merge #3445 before I add a 
comparison test case from this?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/adrian-wang/spark sumempty

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/3675.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3675
    
----
commit 42df76399a9f815ddd235273d32ebfaafcc7c2fe
Author: Daoyuan Wang <daoyuan.w...@intel.com>
Date:   2014-12-11T08:07:54Z

    sum and avg on empty table should always return null

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to