HeartSaVioR edited a comment on issue #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor URL: https://github.com/apache/spark/pull/23854#issuecomment-466872757 d4c2060 only changes parameter names from ca124b9 so the build result would be expected to be same. Btw, while d4c2060 is refactoring on `deserializerFor` between `ScalaReflection` and `JavaTypeInference`, I'm seeing similar needs on `serializerFor`, as well as recording `walkedTypePath`. Would we want to have them refactored similarly? If then I'll work on that in separate JIRA & PR. Thanks!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
