Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3301#issuecomment-67123069
Thanks for these latest changes.
This looks pretty good to me, but I think we can go one step further in
removing the last traces of the WholeTextFile-specific stuff from the
now-generic ConfigurableCombineFileRecordReader class. I've posted my
suggestion as a PR to your PR at https://github.com/davies/spark/pull/2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
