shahidki31 commented on a change in pull request #23939: [SPARK-27019]
[webUI]onJobStart happens after onExecutionEnd shouldn't overwrite kvstore
URL: https://github.com/apache/spark/pull/23939#discussion_r262377988
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListener.scala
##########
@@ -77,7 +77,28 @@ class SQLAppStatusListener(
val executionId = executionIdString.toLong
val jobId = event.jobId
- val exec = getOrCreateExecution(executionId)
+ val exec = Option(liveExecutions.get(executionId))
+ .orElse {
+ try {
+ val sqlStoreData = Some(kvstore.read(classOf[SQLExecutionUIData],
executionId)).get
+ // Should not overwrite the kvstore with new entry, if it already
has the SQLExecution
+ // data corresponding to the execId.
+ val executionData = getOrCreateExecution(executionId)
Review comment:
Actually, in the KVStore, live execution data is written as
'SQLExecutionUIData'. But, in the 'liveExecutions' hash map, we put
'LiveExecutionData'.
So, we cannot directly put 'sqlStoredData' to the 'liveExecutions' map.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
