MaxGekk commented on a change in pull request #24008: [SPARK-24783][SQL]
spark.sql.shuffle.partitions=0 should throw exception
URL: https://github.com/apache/spark/pull/24008#discussion_r263597221
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala
##########
@@ -310,4 +309,11 @@ class SQLConfSuite extends QueryTest with
SharedSQLContext {
SQLConf.unregister(fallback)
}
+ test("SPARK-24783: spark.sql.shuffle.partitions=0 should throw exception ") {
+ val e = intercept[IllegalArgumentException] {
+ spark.conf.set(SQLConf.SHUFFLE_PARTITIONS.key, 0)
Review comment:
Since we expect it should be a positive value, I would check positive
scenario, let's say `Int.MaxValue` and negative one `-1`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
