Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3607#discussion_r22051716
  
    --- Diff: docs/running-on-yarn.md ---
    @@ -92,6 +100,13 @@ Most of the configs are the same for Spark on YARN as 
for other deployment modes
       </td>
     </tr>
     <tr>
    +  <td><code>spark.yarn.am.memoryOverhead</code></td>
    +  <td>AM memory * 0.07, with minimum of 384 </td>
    --- End diff --
    
    would be nice to add comment to spark.yarn.driver.memoryOverhead saying it 
applies in cluster mode.
    
    This config is a bit different from the others as the memory overhead is 
purely a yarn thing and doesn't apply in other modes. ie There is no existing 
spark.driver.memoryOverhead.  We could potentially just use one config for 
this. I'm not sure if that will be more confusing or not though... @sryza 
@vanzin @andrewor14  thoughts on that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to