Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/3680#issuecomment-67567074
@rnowling The update looks good to me. We used Poisson sampler from colt
before, which cannot reset seed. That's why we made new instances in `setSeed`.
Now with commons-math3, we don't need to do this anymore.
There are two things left:
1. Could you add tests in `JavaRandomRDDsSuite`? Just make sure the Java
methods work.
2. Could you create a JIRA for the Python API? It should be in a separate
PR. It is okay if you don't have time to work on it. We just need a reminder.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
