wangjiaochun commented on a change in pull request #24103: [SPARK-27141][YARN]
Use ConfigEntry for hardcoded configs for Yarn
URL: https://github.com/apache/spark/pull/24103#discussion_r266289499
##########
File path:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnAllocatorSuite.scala
##########
@@ -48,8 +49,8 @@ class MockResolver extends SparkRackResolver {
class YarnAllocatorSuite extends SparkFunSuite with Matchers with
BeforeAndAfterEach {
val conf = new YarnConfiguration()
val sparkConf = new SparkConf()
- sparkConf.set("spark.driver.host", "localhost")
- sparkConf.set("spark.driver.port", "4040")
+ sparkConf.set(DRIVER_HOST_ADDRESS.key, "localhost")
+ sparkConf.set(DRIVER_PORT.key, "4040")
Review comment:
Thank you for your suggestion. I will fix it。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
