Github user tgaloppo commented on the pull request:
https://github.com/apache/spark/pull/3022#issuecomment-67717252
I've performed most of the requested changes. I do not see the BLAS
function mentioned (dsyr), so I left this as a TODO. Also, I could not find
EPSILON in MLUtils.
I left predictMembership public and changed predict to predictLabels,
providing soft and hard label assignments, respectively. I know there are some
other thoughts around improving these, but I am not clear on what I should do.
cc: @mengxr @jkbradley
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
