LantaoJin commented on issue #23951: [SPARK-13704][CORE][YARN] Re-implement 
RackResolver to reduce resolving time
URL: https://github.com/apache/spark/pull/23951#issuecomment-475470622
 
 
   > The failure (in 
[`org.apache.spark.scheduler.TaskSchedulerImplSuite`"SPARK-16106 locality 
levels updated if executor added to existing 
host"](https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103786/testReport/junit/org.apache.spark.scheduler/TaskSchedulerImplSuite/SPARK_16106_locality_levels_updated_if_executor_added_to_existing_host/))
 is probably real (you might just need to update the test assertions).
   
   That's because I changed the behavior or `getRackForHost`. The original 
returns `None` by default. Now it returns string "unknown". @squito Should I 
keep current behavior or recover to the original behavior?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to