hehuiyuan commented on a change in pull request #24123: [SPARK-27184][CORE]
Replace 'spark.jars' & 'spark.files' & 'spark.submit.pyFiles' &
'spark.submit.deployMode' with the variables of this config object
URL: https://github.com/apache/spark/pull/24123#discussion_r268029099
##########
File path:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala
##########
@@ -183,9 +183,9 @@ private[deploy] class SparkSubmitArguments(args:
Seq[String], env: Map[String, S
.orElse(sparkProperties.get(config.CORES_MAX.key))
.orNull
name = Option(name).orElse(sparkProperties.get("spark.app.name")).orNull
- jars = Option(jars).orElse(sparkProperties.get("spark.jars")).orNull
- files = Option(files).orElse(sparkProperties.get("spark.files")).orNull
- pyFiles =
Option(pyFiles).orElse(sparkProperties.get("spark.submit.pyFiles")).orNull
+ jars = Option(jars).orElse(sparkProperties.get(config.JARS.key)).orNull
+ files = Option(files).orElse(sparkProperties.get(config.FILES.key)).orNull
+ pyFiles =
Option(pyFiles).orElse(sparkProperties.get(config.SUBMIT_PYTHON_FILES.key)).orNull
Review comment:
> As you are fixing "spark.submit.pyFiles" and "spark.submit.deployMode"
here could you fix it in the other places as well and add it to the PR
description?
Sorry, I don't understand where the other places is.
1 : add an extra pr ？
2: add the description of "spark.submit.pyFiles" and
"spark.submit.deployMode" in this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
