maropu commented on a change in pull request #24158: [SPARK-26847][SQL] Pruning nested serializers from object serializers: MapType support URL: https://github.com/apache/spark/pull/24158#discussion_r268036183
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/objects.scala ########## @@ -121,9 +121,7 @@ object EliminateMapObjects extends Rule[LogicalPlan] { object ObjectSerializerPruning extends Rule[LogicalPlan] { /** - * Collects all struct types from given data type object, recursively. Supports struct and array - * types for now. - * TODO(SPARK-26847): support map type. + * Collects all struct types from given data type object, recursively. */ def collectStructType(dt: DataType, structs: ArrayBuffer[StructType]): ArrayBuffer[StructType] = { Review comment: Visible for testing? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org