gengliangwang commented on a change in pull request #24005: [SPARK-27085][SQL] 
Migrate CSV to File Data Source V2
URL: https://github.com/apache/spark/pull/24005#discussion_r268041550
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala
 ##########
 @@ -163,7 +163,7 @@ class CSVFileFormat extends TextBasedFileFormat with 
DataSourceRegister {
 
 }
 
-private[csv] class CsvOutputWriter(
 
 Review comment:
   I think we can just make it public since the execution package is meant to 
be internal. See the comment 
https://github.com/apache/spark/pull/24005#pullrequestreview-212555802
   
   I will put it into a separate file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to