Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3467#discussion_r22139294
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala ---
    @@ -117,8 +129,9 @@ private[spark] class HistoryPage(parent: HistoryServer) 
extends WebUIPage("") {
       private def appRow(info: ApplicationHistoryInfo): Seq[Node] = {
         val uiAddress = HistoryServer.UI_PATH_PREFIX + s"/${info.id}"
         val startTime = UIUtils.formatDate(info.startTime)
    -    val endTime = UIUtils.formatDate(info.endTime)
    -    val duration = UIUtils.formatDuration(info.endTime - info.startTime)
    +    val endTime = if(info.endTime != -1) UIUtils.formatDate(info.endTime) 
else "-"
    --- End diff --
    
    also might be good to check for `info.endTime > 0` instead, here and other 
places


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to