Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/3632#issuecomment-67757353
On a first pass, this doesn't look right. If you are providing additional
methods that should be available for `RDD[(K, V)]` where there is an `Ordering`
available for both `K` and `V`, then it seems that the strategy that you should
be following should not be to add methods directly to `PairRDD`, but rather to
go one step further than does `OrderedRDD`, whose purpose is to provide
additional methods for `RDD[(K, V)]` where there is an `Ordering` available for
`K`.
Please read this comment:
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/rdd/OrderedRDDFunctions.scala#L26
...and look at how the `Ordering` context bound is used:
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/rdd/OrderedRDDFunctions.scala#L26
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/rdd/OrderedRDDFunctions.scala#L26
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
