Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3754#issuecomment-67782883
This seems fine to me, especially since this only affects test code. I
guess that newer versions of Hadoop have `isSymlink`, so it may not always be
the case that `!isDir` implies `isFile`. That said, it looks like this may be
the best that we can do in Hadoop 1.x ([see
Javadoc](https://hadoop.apache.org/docs/r1.0.4/api/org/apache/hadoop/fs/FileSystem.html#getFileStatus(org.apache.hadoop.fs.Path))),
so I'm fine with merging this.
One minor comment, though: it looks like your PR description / commit
message describes the opposite of this change:
> In Hadoop 1.x, all we have is FileStatus.isFile, so these "is directory"
assertions are changed to "is not a file"
but I think you meant to say
> In Hadoop 1.x, all we have is FileStatus.isDir, so these "is file"
assertions are changed to "is not a directory"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
