Github user liyezhang556520 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3717#discussion_r22152604
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -240,6 +240,8 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with Logging {
/** Checks for illegal or deprecated config settings. Throws an
exception for the former. Not
* idempotent - may mutate this conf object to convert deprecated
settings to supported ones. */
private[spark] def validateSettings() {
+ logInfo(s"Spark Version: $SPARK_VERSION")
+
--- End diff --
Hi @andrewor14 , yes, it does seem like not the right place here, It's
better to put it in `SparkContext`. But the code would be a little ugly if put
the log there, see my next commit in this PR. Is there any better way?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
