Github user zsxwing commented on the pull request:

    https://github.com/apache/spark/pull/3710#issuecomment-67924843
  
    > This looks good to me; I'd say it's ready to merge. Left one really minor 
comment about maybe applying the same stop() fix to LiveListenerBus so that the 
implementations remain in sync.
    
    I pushed a commit to fix the `stop` issue. It's tricky in 
`LiveListenerBus`. @andrewor14 could you review it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to