Github user lianhuiwang commented on a diff in the pull request: https://github.com/apache/spark/pull/3061#discussion_r22245488 --- Diff: core/src/main/scala/org/apache/spark/network/nio/NioBlockTransferService.scala --- @@ -121,8 +132,34 @@ final class NioBlockTransferService(conf: SparkConf, securityManager: SecurityMa }(cm.futureExecContext) future.onFailure { case exception => - blockIds.foreach { blockId => - listener.onBlockFetchFailure(blockId, exception) + exception match { + case connectExcpt: IOException => --- End diff -- because in https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/network/nio/ConnectionManager.scala#L963 doesnot catch ConnectException and throw a IOException. so now in here we only catch IOException. if we are only trying to deal with connection errors, it need to catch ConnectException in ConnectionManager.scala.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org