Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3823#discussion_r22306764
  
    --- Diff: bin/spark-submit ---
    @@ -42,7 +42,10 @@ while (($#)); do
       shift
     done
     
    -DEFAULT_PROPERTIES_FILE="$SPARK_HOME/conf/spark-defaults.conf"
    +DEFAULT_PROPERTIES_FILE="$SPARK_CONF_DIR/spark-defaults.conf"
    +if [ ! -f "DEFAULT_PROPERTIES_FILE" ]; then
    +  DEFAULT_PROPERTIES_FILE="$SPARK_HOME/conf/spark-defaults.conf"
    +fi
     export SPARK_SUBMIT_DEPLOY_MODE=${SPARK_SUBMIT_DEPLOY_MODE:-"client"}
     export 
SPARK_SUBMIT_PROPERTIES_FILE=${SPARK_SUBMIT_PROPERTIES_FILE:-"$DEFAULT_PROPERTIES_FILE"}
    --- End diff --
    
    It's used here actually, but the purpose below seems to be detecting 
whether the user has set particular properties. Finding the default config 
doesn't matter here since it is a case where the user hasn't set these 
properties.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to