Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3809#discussion_r22322821
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -329,8 +329,11 @@ class SparkContext(config: SparkConf) extends Logging
with ExecutorAllocationCli
try {
dagScheduler = new DAGScheduler(this)
} catch {
- case e: Exception => throw
- new SparkException("DAGScheduler cannot be initialized due to
%s".format(e.getMessage))
+ case e: Exception => {
+ stop()
--- End diff --
Also, do you think this should be in a try-finally block so that we don't
swallow the useful "DAGScheduler could not be initialized" exception if the
stop() call somehow fails?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
