dongjoon-hyun commented on a change in pull request #24441: [SPARK-27494][SS]
Null values don't work in Kafka source v2
URL: https://github.com/apache/spark/pull/24441#discussion_r277570191
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaRecordToUnsafeRowConverter.scala
##########
@@ -36,7 +36,11 @@ private[kafka010] class KafkaRecordToUnsafeRowConverter {
} else {
rowWriter.write(0, record.key)
}
- rowWriter.write(1, record.value)
+ if (record.value == null) {
+ rowWriter.setNullAt(1)
+ } else {
+ rowWriter.write(1, record.value)
+ }
Review comment:
Please update the PR description. If `existing unit tests` already covers
your case, Apache Spark don't need this PR. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
