viirya commented on a change in pull request #24440: [SPARK-27545] [SQL]
Uncache table needs to delete the temporary view …
URL: https://github.com/apache/spark/pull/24440#discussion_r277619263
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala
##########
@@ -442,7 +442,11 @@ class CatalogImpl(sparkSession: SparkSession) extends
Catalog {
override def uncacheTable(tableName: String): Unit = {
val tableIdent =
sparkSession.sessionState.sqlParser.parseTableIdentifier(tableName)
val cascade = !sessionCatalog.isTemporaryTable(tableIdent)
-
sparkSession.sharedState.cacheManager.uncacheQuery(sparkSession.table(tableName),
cascade)
+ val wasCached =
Try(sparkSession.catalog.isCached(tableIdent.unquotedString)).getOrElse(false)
+ if (wasCached) {
+
sparkSession.sharedState.cacheManager.uncacheQuery(sparkSession.table(tableIdent),
cascade)
+ sparkSession.sessionState.catalog.dropTempView(tableIdent.table)
Review comment:
If the table is not a temporary view, no need to drop it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
