10110346 opened a new pull request #24446: [SPARK-27552][SQL]The configuration 
`hive.exec.stagingdir` is invalid on Windows OS
URL: https://github.com/apache/spark/pull/24446
 
 
   ## What changes were proposed in this pull requesst?
   If we set `hive.exec.stagingdir=.test-staging\tmp`,
   But the staging directory is still `.hive-staging` on Windows OS.
   
   Reasons for failure:
   Test code:
   ```
    val path = new Path("C:\\test\\hivetable")
     println("path.toString: " + path.toString)
     println("path.toUri.getPath: " + path.toUri.getPath)
   ```
   
   Output:
   ```
   path.toString: C:/test/hivetable
   path.toUri.getPath: /C:/test/hivetable
   ```
    We can see that `path.toUri.getPath` has one more separator than 
`path.toString`,  and the separator is   ' / ',  not  ' \ '
   So 
`stagingPathName.stripPrefix(inputPathName).stripPrefix(File.separator).startsWith(".")`
 will return false
   ## How was this patch tested?
   Existed tests
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to