Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3849#issuecomment-68407820 Annoyingly, it looks like ScalaDoc doesn't display Javadoc annotations, so in the Scala documentation for 1.2.0 the TaskContext class appears to have lost all documentation, even though it still shows up in the Java docs: - http://spark.apache.org/docs/1.2.0/api/scala/index.html#org.apache.spark.TaskContext - https://spark.apache.org/docs/1.2.0/api/java/org/apache/spark/TaskContext.html I don't know how the docs for `attemptId` managed to get lost during the TaskContext stabilization patch, but this suggests that we need a better review checklist for public APIs which mandates full Scaladoc / Javadoc for all public interfaces.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org