Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3849#discussion_r22375124
  
    --- Diff: 
core/src/test/scala/org/apache/spark/scheduler/TaskContextSuite.scala ---
    @@ -63,6 +63,33 @@ class TaskContextSuite extends FunSuite with 
BeforeAndAfter with LocalSparkConte
     
         verify(listener, times(1)).onTaskCompletion(any())
       }
    +
    +  test("TaskContext.attemptNumber should return attempt number, not task 
id (SPARK-4014)") {
    +    sc = new SparkContext("local-cluster[2,1,512]", "test")
    --- End diff --
    
    Just realized that I can change the `maxFailures` property on `local` 
instead of having to use `local-cluster`.  Let me make that change, since it's 
a better practice and will speed up the tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to