gengliangwang commented on a change in pull request #24598: [SPARK-27699][SQL]
Partially push down disjunctive predicated in Parquet/ORC
URL: https://github.com/apache/spark/pull/24598#discussion_r284972693
##########
File path:
sql/core/v1.2.1/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilters.scala
##########
@@ -75,10 +75,42 @@ private[sql] object OrcFilters extends OrcFiltersBase {
schema: StructType,
dataTypeMap: Map[String, DataType],
filters: Seq[Filter]): Seq[Filter] = {
- for {
- filter <- filters
- _ <- buildSearchArgument(dataTypeMap, filter, newBuilder())
- } yield filter
+ import org.apache.spark.sql.sources._
+
+ def convertibleFiltersHelper(
Review comment:
This is a helper method for converting Filter to Expression recursively. It
can also be `_convertibleFilters` or `convertibleFilters0`...
Here it is following `createFilterHelper` in `ParquetFilters`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
