[GitHub] [spark] shahidki31 commented on a change in pull request #24609: [SPARK-27715][SQL] SQL query details in UI dose not show in correct format.

[GitBox]

shahidki31 commented on a change in pull request #24609: [SPARK-27715][SQL] SQL 
query details in UI dose not show in correct format.
URL: https://github.com/apache/spark/pull/24609#discussion_r284978946
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
 ##########
 @@ -382,13 +382,14 @@ private[ui] class ExecutionPagedTable(
   }
 
   private def descriptionCell(execution: SQLExecutionUIData): Seq[Node] = {
+    val jobDescription = UIUtils.makeDescription(execution.description, 
basePath, plainText = false)
     val details = if (execution.details != null && execution.details.nonEmpty) 
{
       <span 
onclick="this.parentNode.querySelector('.stage-details').classList.toggle('collapsed')"
             class="expand-details">
         +details
       </span> ++
       <div class="stage-details collapsed">
-        <pre>{execution.description}<br></br>{execution.details}</pre>
+        <pre>{jobDescription}<br></br>{execution.details}</pre>
 
 Review comment:
   In the `details`, before this change it used to show entire query if the 
query is large. But after the change it seems, it seems not showing the entire 
sql query.
   
   **Before change:** 
   ![Screenshot from 2019-05-17 
10-29-07](https://user-images.githubusercontent.com/23054875/57904103-01f4fd00-788f-11e9-9746-0f3692f64339.png)
   
   **After change:**
   ![Screenshot from 2019-05-17 
10-30-56](https://user-images.githubusercontent.com/23054875/57904112-09b4a180-788f-11e9-96db-61fb4a6df750.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org