Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/3543#issuecomment-68758185
Just for posterity: I think a couple of changes sneaked in between my
original change being sent as a PR and it being commited, making my code miss
some `Configuration` instantiations.
At that time, I explicitly avoided changing default arguments to a few
methods (since my thinking was that since it's an argument, the user should
know what he's doing). But I don't really have an opinion about what's the
right approach there, and changing it is fine with me.
I also don't have enough background to comment on the thread-safety issues
(others have looked at it in much more depth than I have)...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
