dilipbiswal commented on a change in pull request #24344: [SPARK-27440][SQL]
Optimize uncorrelated predicate subquery
URL: https://github.com/apache/spark/pull/24344#discussion_r285887952
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
##########
@@ -93,6 +93,21 @@ object SubqueryExpression {
}.isDefined
}
+ /**
+ * Returns true when an expression contains a correlated IN or correlated
EXISTS and
+ * false otherwise. An IN is non-correlated only if the left values are
foldable
+ * and the subquery has no outer references.
+ */
+ def hasCorrelatedInOrExists(e: Expression): Boolean = {
+ e.find {
+ case InSubquery(values, ListQuery(_, children, _, _)) =>
+ values.exists(!_.foldable) || children.nonEmpty
+ case Exists(_, children, _) =>
+ children.nonEmpty
+ case _ => false
+ }.isDefined
+ }
+
Review comment:
@francis0407 sorry, the query is :
select * from s where x in (select c1 from values (1), (2), (3) foo(c1));
Would the caller of our new function expect this to be a correlated query ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
