Github user srowen commented on the pull request: https://github.com/apache/spark/pull/3874#issuecomment-68773133 The only risk here is that this increases surface area for Guava version conflict, which was the whole point of the shading. Elmer has some analysis of what happens when you do this in the JIRA: https://issues.apache.org/jira/browse/SPARK-5052?focusedCommentId=14262740&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14262740 I'm still not sure why the heck the `Partition` class isn't found if you just bundle your own Guava, which is how it's "supposed" to be done (right?). That seems like the path of least resistance. I haven't had a chance to look at that more.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org