skonto commented on a change in pull request #24613: [SPARK-27549][SS] Add
support for committing kafka offsets per batch for supporting external tooling
URL: https://github.com/apache/spark/pull/24613#discussion_r286169217
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchStream.scala
##########
@@ -168,7 +174,15 @@ private[kafka010] class KafkaMicroBatchStream(
KafkaSourceOffset(JsonUtils.partitionOffsets(json))
}
- override def commit(end: Offset): Unit = {}
+ override def commit(end: Offset): Unit = {
+ if (shouldSetCommitOffsetsOnCheckpoints) {
Review comment:
@gaborgsomogyi I was checking the calls and I dont see any exception thrown
from my code.
I could add it just to be over-protective.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
