JoshRosen commented on a change in pull request #24668: [SPARK-27676][SQL][SS] 
InMemoryFileIndex should respect spark.sql.files.ignoreMissingFiles
URL: https://github.com/apache/spark/pull/24668#discussion_r286292793
 
 

 ##########
 File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileIndexSuite.scala
 ##########
 @@ -178,6 +178,41 @@ class FileIndexSuite extends SharedSQLContext {
     }
   }
 
+  test("SPARK-27676: InMemoryFileIndex respects ignoreMissingFiles config for 
non-root paths") {
 
 Review comment:
   Good point. In the case of a parallel listing, this would cause the listing 
Spark job to fail with a `FileNotFoundException` (after maxTaskRetries attempts 
to list the missing file).
   
   In the interests of complete test coverage, I'll update the test case to 
exercise the parallel listing path, too. 
   
   (Combinatorial test coverage is hard!) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to