Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3638#discussion_r22503283
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -266,8 +267,18 @@ private[spark] class TaskSchedulerImpl(
assert(availableCpus(i) >= 0)
launchedTask = true
}
+ } catch {
+ case e: TaskNotSerializableException => {
+ return
--- End diff --
This could probably use a descriptive comment to explain that the error is
already logged elsewhere. On the other hand, I suppose that it doesn't hurt to
add a redundant logging statement here, too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
