vanzin commented on a change in pull request #24499: [SPARK-27677][Core] Serve
local disk persisted blocks by the external service after releasing executor by
dynamic allocation
URL: https://github.com/apache/spark/pull/24499#discussion_r286704956
##########
File path:
core/src/test/scala/org/apache/spark/ExternalShuffleServiceSuite.scala
##########
@@ -92,4 +95,40 @@ class ExternalShuffleServiceSuite extends ShuffleSuite with
BeforeAndAfterAll {
}
e.getMessage should include ("Fetch failure will not retry stage due to
testing config")
}
+
+ test("SPARK-25888: using external shuffle service fetching disk persisted
blocks") {
+ sc = new SparkContext("local-cluster[1,1,1024]", "test", conf)
+ sc.env.blockManager.externalShuffleServiceEnabled should equal(true)
+ sc.env.blockManager.shuffleClient.getClass should
equal(classOf[ExternalShuffleClient])
+
+ val rdd = sc.parallelize(0 until 100, 2)
+ .map { i => (i, 1) }
+ .persist(StorageLevel.DISK_ONLY)
+
+ rdd.count()
+
+ val blockId = RDDBlockId(rdd.id, 0)
+ eventually(timeout(2.seconds), interval(100.milliseconds)) {
+ val locations = sc.env.blockManager.master.getLocations(blockId)
+ assert(locations.size === 2)
+ assert(locations.map(_.port).contains(server.getPort),
+ "external shuffle service port should be contained")
+ }
+
+ sc.killExecutors(sc.getExecutorIds())
+
+ eventually(timeout(2.seconds), interval(100.milliseconds)) {
+ val locations = sc.env.blockManager.master.getLocations(blockId)
+ assert(locations.size === 1)
+ assert(locations.map(_.port).contains(server.getPort),
+ "external shuffle service port should be contained")
+ }
+
+ assert(sc.env.blockManager.getRemoteValues(blockId).isDefined)
+
+ // test unpersist: as executors are killed the blocks will be removed via
the shuffle service
+ rdd.unpersist(true)
+ assert(sc.env.blockManager.getRemoteValues(blockId).isEmpty)
+ rpcHandler.applicationRemoved(sc.conf.getAppId, true)
Review comment:
It's unclear what this is testing, since there are not asserts after this
line. Or maybe this is cleanup? (Then it should be in a finally or after block.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
