Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/3898#discussion_r22511002
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -427,6 +427,13 @@ private[hive] case class MetastoreRelation
.getOrElse(sqlContext.defaultSizeInBytes))
}
)
+ override def sameResult(plan: LogicalPlan): Boolean = {
+ val new_plan = plan.asInstanceOf[MetastoreRelation];
--- End diff --
what about when its not a metastore relation? how about:
```scala
plan match {
case mr: MetastoreRelation =>
mr.databaseName == databaseName && mr.tableName == tableName
case _ => false
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
