Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3888#issuecomment-68833871
This is simpler, but it has several disadvantages to the other approach:
- The InSet it collected to the driver and thus could cause OOMs when large
- I don't think that it handles correlated subqueries
- The `execute()` involves eager evaluation and breaks RDD lineage
For these reasons I think we should stick to extending the approach taken
by the other PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
