rdblue commented on a change in pull request #24686: [SPARK-27813][SQL]
DataSourceV2: Add DropTable logical operation
URL: https://github.com/apache/spark/pull/24686#discussion_r288710143
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala
##########
@@ -83,6 +84,15 @@ case class DataSourceResolution(
s"No catalog specified for table ${identifier.quoted} and no
default catalog is set"))
.asTableCatalog
convertCTAS(catalog, identifier, create)
+
+ case DropTableStatement(CatalogObjectIdentifier(Some(catalog), ident),
ifExists, _) =>
+ DropTable(catalog.asTableCatalog, ident, ifExists)
+
+ case DropTableStatement(AsTableIdentifier(tableName), ifExists, purge) =>
+ DropTableCommand(tableName, ifExists, false, purge)
Review comment:
Boolean arguments should use the named form: `isView = false`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
